Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support short PHP tags #1840

Closed
bitwiseman opened this issue Sep 21, 2020 · 0 comments
Closed

Support short PHP tags #1840

bitwiseman opened this issue Sep 21, 2020 · 0 comments

Comments

@bitwiseman
Copy link
Member

bitwiseman commented Sep 21, 2020

PHP now allows <? ... ?> tags. We currently only recognize <?= and <?php as the start of php tags.

https://github.com/beautify-web/js-beautify/blob/0500e504796bda1ebd17d4e38ea56387532751d1/test/data/html/tests.js#L2120

https://github.com/beautify-web/js-beautify/blob/510cf7a9a82cb7f7515ac6988554086d0e5a7bc8/js/src/core/templatablepattern.js#L59

https://github.com/beautify-web/js-beautify/blob/71b6545d85577067e572fe6d8392c97395d21b38/python/jsbeautifier/core/templatablepattern.py#L45

Note: the allowed pattern will need to be <?_ (with a space) to avoid collision with <?xml tags and the like.

@StarWars-Figurendotcom
Copy link

Who can point me into the right direction? We have a news site with a java script scroller, how can I get the images big once someone hovers over the image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant