Do not use hardcoded directory for tests #788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hardcoded /tmp/js-beautify-mkdir directory path is used for tests, and this directory it not removed after tests. This can cause multiplie issues on a build server: - if multiple builds are running js-beautify tests concurrently, they may try to manipulate the directory at the same time, and step on each other's toes - if multiple users are using the same build machine, since /tmp/js-beautify-mkdir is not removed after tests, the permissions on /tmp/js-beautify-mkdir will prevent another user to run tests
| touch -A -01 $JS_BEAUTIFY_MKDIR/js-beautify-old.js | ||
| $CLI_SCRIPT -r $JS_BEAUTIFY_MKDIR/js-beautify.js && test $JS_BEAUTIFY_MKDIR/js-beautify.js -nt $JS_BEAUTIFY_MKDIR/js-beautify-old.js && { | ||
| echo "js-beautify should not replace unchanged file $JS_BEAUTIFY_MKDIR/js-beautify.js when using -r" | ||
| rm -rf $JS_BEAUTIFY_MKDIR |
There was a problem hiding this comment.
Instead of adding this multiple times, could you move this and the exit 1 into a function?
|
Great contribution. Could you make the requested tweak, and repeat this change for the other shell testing wrapper scripts? |
|
@blino - Ping? |
|
Hi, |
|
You had it mostly done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hardcoded /tmp/js-beautify-mkdir directory path is used for tests,
and this directory it not removed after tests.
This can cause multiplie issues on a build server:
to manipulate the directory at the same time, and step on each other's toes
/tmp/js-beautify-mkdir is not removed after tests, the permissions on
/tmp/js-beautify-mkdir will prevent another user to run tests