Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable line-length linter lll for comments #348

Closed
carreter opened this issue Sep 16, 2023 · 1 comment
Closed

Enable line-length linter lll for comments #348

carreter opened this issue Sep 16, 2023 · 1 comment
Assignees
@carreter
Labels
wontfix This will not be worked on

Comments

@carreter
Copy link
Collaborator

Enable lll in .golangci.yml and configure it to only apply to lines that have comments in them. This won't apply to multiline /* */ comments unfortunately, but it'd be a start to have it on // comments.
@carreter carreter added enhancement New feature or request easy A quick and easy fix! devops Improvements to DevOps (e.g. GitHub actions, linting, etc.) low priority Would be nice to fix, but doesn't have to happen right now/there are more important things labels Sep 16, 2023
@carreter carreter self-assigned this Sep 16, 2023
@carreter carreter modified the milestone: v1.0 Sep 23, 2023
@carreter
Copy link
Collaborator Author

Turns out that it isn't really possible to exclude non-comment lines easily. Since it's not a huge deal, will close as wont-fix.

@carreter carreter closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2023
@carreter carreter added wontfix This will not be worked on and removed enhancement New feature or request easy A quick and easy fix! devops Improvements to DevOps (e.g. GitHub actions, linting, etc.) low priority Would be nice to fix, but doesn't have to happen right now/there are more important things labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carreter carreter

Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carreter