Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Calls to checks for a speific check return undefined #1

Closed
rwky opened this issue Aug 2, 2013 · 3 comments · Fixed by #2
Closed

Calls to checks for a speific check return undefined #1

rwky opened this issue Aug 2, 2013 · 3 comments · Fixed by #2

Comments

@rwky
Copy link
Contributor

rwky commented Aug 2, 2013

If you run checks with the target option then the callback receives undefined because Pingdom's API returns 'check' instead of 'checks'.

The property variable needs to be set to 'check' for this kind of check.

api.checks(function(err,check) { 
    console.log(check); //outputs undefined
},{target:111111});
@bebraw
Copy link
Owner

bebraw commented Aug 2, 2013

Valid point. I'll accept a PR for this gladly. If you aren't in a hurry I'll eventually fix this on my own, though. :)

@rwky
Copy link
Contributor Author

rwky commented Aug 2, 2013

I'll create a PR next week, after I've played with the API a bit more.

@bebraw
Copy link
Owner

bebraw commented Aug 2, 2013

Ok, great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants