Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crates.io links cannot be resolved #20

Closed
stanislav-tkach opened this issue Aug 30, 2020 · 4 comments
Closed

crates.io links cannot be resolved #20

stanislav-tkach opened this issue Aug 30, 2020 · 4 comments

Comments

@stanislav-tkach
Copy link

No crates.io links can be resolved. For example, a file only contains a single link:

https://crates.io/crates/tokio

mlc gives the following output:

> mlc

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+                                                          +
+            markup link checker - mlc v0.13.4             +
+                                                          +
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

[Err ] ./test.md (1, 1) => https://crates.io/crates/tokio. 404 - Not Found

Result (1 links):

OK       0
Skipped  0
Warnings 0
Errors   1


The following links could not be resolved:

./test.md (1, 1) => https://crates.io/crates/tokio.

By the way, are all browser and smartphone details in the issue template really needed for this project?

@becheran
Copy link
Owner

Hey, thank you very much for opening an issue. Unfortunately I cannot really solve this issue. All crates.io pages have the same problem. I also get a 404 when I query the page with curl curl https://crates.io/crates/tokio {"errors":[{"detail":"Not Found"}]} I guess it is intentionally that crates.io shall only be visible to web-browsers.

And yes, I will update the template. Absolutely no need for this info.

@mvlabat
Copy link

mvlabat commented Aug 30, 2020

@becheran I believe this can be worked around with adding this header to the requests: Accept: text/html
rust-lang/crates.io#788

@becheran
Copy link
Owner

Right. Thanks @mvlabat. I added the header info and it works. I will push and release an updated version with the fix. Many thanks

@stanislav-tkach
Copy link
Author

Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants