Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object is a reserved keyword in php 7.2 #231

Closed
balrok opened this issue Dec 15, 2017 · 7 comments
Closed

Object is a reserved keyword in php 7.2 #231

balrok opened this issue Dec 15, 2017 · 7 comments

Comments

@balrok
Copy link

balrok commented Dec 15, 2017

For example src/components/Helper.php should not inherit from Object. The yii team renamed it to BaseObject

@balrok balrok changed the title Object is a reversed keyword in php 7.2 Object is a reserved keyword in php 7.2 Dec 15, 2017
@karataserkan
Copy link
Contributor

karataserkan commented Jan 10, 2018

We can not use Yii versions <2.0.13 to be compatible with PHP 7.2 or higher. Our composer.json requires "yiisoft/yii2": "2.*".
To compatible with PHP 7.2 or higher, we also update our composer.json. I think we should not do that.
Yii2 Audit sould be compatible with Yii versions <2.0.13. But it should be changed with new version 1.1 or 1.0.13.

@balrok
Copy link
Author

balrok commented Jan 10, 2018

Hi,
I forked this project to fix this issue: https://github.com/balrok/yii2-audit
At the bottom of the readme is also how you can add it to the composer.json

@Blizzke
Copy link
Member

Blizzke commented Jan 10, 2018

Just wanted to let it be known that it is not because we currently have very little time to fix issues ourselves that we won't merge pull requests and draft new releases for them.
So feel free to submit a PR for this and we'll take care of it.

@StalkAlex
Copy link
Contributor

@balrok why just not create PR instead of fork?

@balrok
Copy link
Author

balrok commented Jan 17, 2018

Please do it for me - I never did a pull request.

On the other hand the maintainer could simply:

wget https://github.com/balrok/yii2-audit/commit/33b6c4bc27823bd982ab2d5227ee955b95749d00.patch
patch -d . -p1 < 33b6c4bc27823bd982ab2d5227ee955b95749d00.patch

edit: reading #235 I see why it is not such a simple matter..
But on the other hand maybe yii2-audit should just get a version upgrade for this feature and be done with it. Tell poeple to use version x for older yii and version y for newer yii.

@Blizzke
Copy link
Member

Blizzke commented Jan 20, 2018

New releases 1.0.13 and 1.1.0 resolve this.

1.0.13 is for PHP < 7.2, it will work for all Yii2 versions
1.1.0 is for PHP >= 7.2 and requires at least Yii2 2.0.13

@Blizzke Blizzke closed this as completed Jan 20, 2018
@balrok
Copy link
Author

balrok commented Jan 20, 2018

Your work is really appreciated. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants