Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary compile scope dependency on kerb-simplekdc drags in a lot of dependencies #35

Closed
aggregat4 opened this issue Jul 12, 2021 · 3 comments
Assignees
Milestone

Comments

@aggregat4
Copy link

We use kerb4j successfully (thanks!) but the kerb4j-common library keeps coming up on thirdparty version and security issue reviews in our company.

I looked into the dependencies and the very large dependency tree of kerb4j-common is caused by it dependending on org.apache.kerby:kerb-simplekdc. This appears to be a KDC test server implementation that has a bunch of additional dependencies.

kerb4j-common only needs these dependencies for unit tests.

I have locally cloned the kerb4j repository and and set the dependency to <scope>test</scope> for kerb4j-common and I have additionally added the dependency (as a test dependency) to the following projects:

  • kerb4j-client
  • kerb4j-server-spring-security
  • kerb4j-server-tomcat

After this change, a mvn clean install on the current master version builds and tests fine.

@bedrin
Copy link
Owner

bedrin commented Jul 12, 2021

Thanks for reporting it! Happy to accept the PR if you want to get it released faster :)
Otherwise I'll check later this week when I have time.

@aggregat4
Copy link
Author

aggregat4 commented Jul 12, 2021

Done. Note that I did not execute any additional tests aside from mvn clean install.

@bedrin bedrin added this to the 0.1.2 milestone Jul 12, 2021
@bedrin bedrin self-assigned this Jul 12, 2021
@bedrin
Copy link
Owner

bedrin commented Jul 12, 2021

Thanks for PR. I've merged it and released version 0.1.2
It has been published to Maven Central but might take an hour or two to become available

@bedrin bedrin closed this as completed Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants