Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

PHP 56 compatibility #40

Closed
woqs opened this issue Apr 1, 2019 · 2 comments
Closed

PHP 56 compatibility #40

woqs opened this issue Apr 1, 2019 · 2 comments

Comments

@woqs
Copy link

woqs commented Apr 1, 2019

Hi,

From version 2.1.0 you are telling on composer.json that your library is compatible with php 5.6 or above.

You're using the ?? in CassandraDataCollector though, making it 7.0 or above compliant.

Could you change this, by making a version compatible with 56 (like isset($a['a'])? $a['a'] : '';), and another one with the composer.json modified?

Thanks

@omansour
Copy link
Contributor

omansour commented Apr 2, 2019

thanks for the contribution

as PHP 5.6 is no more supported, I think I will update the requirement in the composer.json to php 7.2

@woqs
Copy link
Author

woqs commented Apr 3, 2019

Thanks!

Have a nice day

@woqs woqs closed this as completed Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants