Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore email case when accepting invites after signup #100

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Ignore email case when accepting invites after signup #100

merged 1 commit into from
Feb 23, 2018

Conversation

mwayne
Copy link
Contributor

@mwayne mwayne commented Feb 21, 2018

When using django-allauth and ACCEPT_INVITE_AFTER_SIGNUP, the Invitation object is obtained by using the new User's email address. Even if a user signs up with an email that differs from the one used on the invite, allauth will normally still associate the Invitation email address with the new User.

If a user simply alters the case of the email address during signup (user@example.com -> USER@EXAMPLE.COM), allauth's cleanup_email_addresses() function can result in the new User email matching the case given during signup, rather than the case used on the invite. This will cause the invite to never properly be accepted, as the current implementation of accept_invite_after_signup() does not ignore case.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 39.025% when pulling 4cc21e3 on mwayne:bug/invitations-case-sensitive-email into 39c10b8 on bee-keeper:master.

@coveralls
Copy link

coveralls commented Feb 21, 2018

Coverage Status

Coverage increased (+0.007%) to 38.802% when pulling 4cc21e3 on mwayne:bug/invitations-case-sensitive-email into 39c10b8 on bee-keeper:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 39.025% when pulling 4cc21e3 on mwayne:bug/invitations-case-sensitive-email into 39c10b8 on bee-keeper:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 39.025% when pulling 4cc21e3 on mwayne:bug/invitations-case-sensitive-email into 39c10b8 on bee-keeper:master.

@bee-keeper
Copy link
Member

Thanks for this. Appreciate the test as well!

@bee-keeper bee-keeper merged commit 22f9701 into jazzband:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants