Make accept-invite viewname configurable in django settings #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valberg
reviewed
Mar 31, 2022
| @@ -98,5 +98,12 @@ def ADMIN_CHANGE_FORM(self): | |||
| "invitations.forms.InvitationAdminChangeForm" | |||
| ) | |||
|
|
|||
| @property | |||
| def COMFIRMATION_VIEWNAME(self): | |||
There was a problem hiding this comment.
Can we call it CONFIRMATION_URL_NAME since it's the name of the URL pattern we are referring to?
There was a problem hiding this comment.
I've removed the source repository a long time ago and can't find a way to update this PR. I guess I'll have to create a new branch and new PR
There was a problem hiding this comment.
Roger that - maybe you can use the .patch as a starting point: https://github.com/jazzband/django-invitations/pull/108.patch
|
@BartoszCki Let us get this in! Can you deal with the conflicts and rename the setting as per my comment? |
|
Created new PR with the same changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to change the invitation link using Django settings