Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mounting): consider base and appBase paths #623

Merged
merged 5 commits into from Feb 18, 2023
Merged

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Feb 17, 2023

Changes Made

Use basePath when disableListen is true. This may fix the case when using fastify

Potential Risks

Test Plan

Checklist

  • I've increased test coverage
  • Since this is a public repository, I've checked I'm not publishing private data in the code, commit comments, or this PR.

Copy link
Collaborator

@richardmaysundo richardmaysundo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roggervalf roggervalf merged commit 387e3ac into master Feb 18, 2023
@roggervalf roggervalf deleted the fix-use-fastify branch February 18, 2023 02:59
beequeueci pushed a commit that referenced this pull request Feb 18, 2023
### [3.30.4](v3.30.3...v3.30.4) (2023-02-18)

### Bug Fixes

* **mounting:** differentiate base and appBase paths when disableListen ([#623](#623)) ([387e3ac](387e3ac))
@beequeueci
Copy link
Collaborator

🎉 This PR is included in version 3.30.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants