Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube Video ID Regex too broad, fails on SSN #33

Closed
bee-san opened this issue May 23, 2021 · 0 comments · Fixed by #36
Closed

YouTube Video ID Regex too broad, fails on SSN #33

bee-san opened this issue May 23, 2021 · 0 comments · Fixed by #36

Comments

@bee-san
Copy link
Owner

bee-san commented May 23, 2021

Regex fails if we use the SSN from : https://www.ssa.gov/history/ssn/misused.html

078-05-1120

It matches as a youtube video-id first. Ideally we:

  • Move SSN physically up the JSON file
    So it matches on SSN first?

Alternatively a #29 filter system but I think physically moving the regex is fine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant