Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

[feature] auto slippage or set several slippage #46

Open
ahdsafw opened this issue Nov 10, 2021 · 6 comments
Open

[feature] auto slippage or set several slippage #46

ahdsafw opened this issue Nov 10, 2021 · 6 comments
Labels
help wanted Extra attention is needed

Comments

@ahdsafw
Copy link

ahdsafw commented Nov 10, 2021

Hi , could you please add smart try different slippage function when buy/sell now or make order ?
sometimes , the slippage often changes very large such as 10-13% during volatile price .
so ,i wish a feature that allows me to set slippage scope when i bue/sell now or make order.
Thanks.

@beeb
Copy link
Owner

beeb commented Nov 10, 2021

How do you propose to implement this? Please describe the algorithm in pseudo-code.

@beeb beeb added the help wanted Extra attention is needed label Nov 10, 2021
@beeb
Copy link
Owner

beeb commented Nov 10, 2021

Please note that you can customize the slippage for each order that you make with "+ Create order" button or /addorder command. The slippage is the maximum price movement that you are willing to accept (includes any token transaction tax that might be applied). It doesn't need a range. Having a range (scope like you said) is the same as having one value. If you expect price change 10-13% then put your slippage at 13+%.

@ahdsafw
Copy link
Author

ahdsafw commented Nov 10, 2021

thank you

@ssergiio
Copy link

ssergiio commented Dec 14, 2021

@beeb

  1. buy/sell order is set
  2. request to honeypot.is/?address=TOKENADDRESS is made
  3. data is parsed to get actual buy/sell tax
  4. slippage of the token gets changed according to the parsed data
  5. buy/sell order is triggered

@beeb
Copy link
Owner

beeb commented Dec 14, 2021

I do not like the idea of relying on an external api for this, as I've observed they have hardcoded the binance rpc url in there which is known to frequently be out of sync when the network is busy. Also, this service only works for BNB LP (they have a separate page for BUSD, but none for USDT AFAIK). They use a smart contract in the background to perform these checks. If anyone knows how they do it, it would be feasible to make a more generic and better version which pancaketrade could query with an rpc call directly.

@beeb
Copy link
Owner

beeb commented Dec 14, 2021

Also, I think this is dangerous as some token developers implement high tax at launch to prevent bots, which if applied without any safeguard, could lead to lost funds

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants
@beeb @ahdsafw @ssergiio and others