Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lominus will not download from directory with more than 30 items #91

Closed
markusyeo opened this issue Oct 17, 2022 · 4 comments
Closed

Lominus will not download from directory with more than 30 items #91

markusyeo opened this issue Oct 17, 2022 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@markusyeo
Copy link

On macos, Lominus is not downloading from Canvas where there are more than 30 items in the source

@markusyeo markusyeo changed the title [Urgent] Lominus will not download from directory with more than 30 items Lominus will not download from directory with more than 30 items Oct 17, 2022
@Beebeeoii
Copy link
Owner

unfortunately this is due to a bandaid fix from #56. relates to #55. this will be one of the top priority to be fixed next.

@Beebeeoii Beebeeoii added the bug Something isn't working label Oct 18, 2022
@markusyeo
Copy link
Author

I see, I will just recompile with the same dirty trick and increase the per_page to 100

@Beebeeoii
Copy link
Owner

yup that would work ! pasting here for ease of reference:

CANVAS_MODULES_ENDPOINT = "https://canvas.nus.edu.sg/api/v1/courses?per_page=30"
CANVAS_MODULE_FOLDERS_ENDPOINT = "https://canvas.nus.edu.sg/api/v1/courses/%s/folders?per_page=30"
CANVAS_FOLDERS_ENDPOINT = "https://canvas.nus.edu.sg/api/v1/folders/%s/folders?per_page=30"
CANVAS_FILES_ENDPOINT = "https://canvas.nus.edu.sg/api/v1/folders/%s/files?per_page=30"

@Beebeeoii
Copy link
Owner

this should be fixed with #102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants