-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comrade for neovim conflicts with gitgutter navigation #6
Comments
The function to do Had a quick look, it feels the two should work fine with each other since they both use their one buffer var to record the sign info. Maybe check the To inspect the vars, try:
this should show all buffer var used by gitgutter (I didn't try :B) |
Will report back here, thanks for taking a look! |
It seems that somehow Comrade is some how wiping out gitgutter's hunk bufvar (along with others). Loading test file without comrade enabled:
With comrade enabled:
Loading test file (second time) without comrade enabled:
|
If I exit studio, and then load the file with comrade, the buffer remains untouched and navigation remains ok! |
Okay, seems like the problem is here: When comrade is enabled this function return false, and the value returned by: When Comrade is disabled: Somehow comrade is setting the buftype to empty as its probably writing to a buffer linked to the studio process. |
I realize that this may not be an issue with Comrade, however I'm remarking here in the event it is.
Comrade uses the sign column, however it stops GitGutter from working effectively, namely it interferes with GitGutter's navigational commands:
I don't know why, but I'm happy to help look into what is going on if I can maybe get a few hints from the original developer her how to do so (I'm not very familiar with vim plugin dev)
The text was updated successfully, but these errors were encountered: