Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

"Vault type" filter shows all vaults when it doesn't match anything. #222

Closed
sirbeefalot opened this issue Mar 12, 2021 · 0 comments · Fixed by #284
Closed

"Vault type" filter shows all vaults when it doesn't match anything. #222

sirbeefalot opened this issue Mar 12, 2021 · 0 comments · Fixed by #284
Labels
bug Something isn't working

Comments

@sirbeefalot
Copy link

I noticed this while implementing the multichain toggle. I don't know if it's the expected outcome.

To reproduce

If you're in a chain like HECO, where we don't currently have single asset vaults. Selecting "Single Assets" in the "Vault type" filter will display all vaults.

Expected outcome

Showing no vaults is what would normally happen in my mind. Don't know if there's a better argument to show everything.
@sirbeefalot sirbeefalot added the bug Something isn't working label Mar 12, 2021
@sirbeefalot sirbeefalot changed the title "Vault Type" filter shows all vaults when it doesn't match anything. "Vault type" filter shows all vaults when it doesn't match anything. Mar 12, 2021
@Mo0o0d Mo0o0d mentioned this issue Apr 5, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vault type fix Mo0o0d/beefy-app
1 participant
@sirbeefalot