Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move react and react-dom from dependencies to peerDependencies #28

Closed
bogdansoare opened this issue Nov 7, 2017 · 3 comments
Closed

Move react and react-dom from dependencies to peerDependencies #28

bogdansoare opened this issue Nov 7, 2017 · 3 comments

Comments

@bogdansoare
Copy link

Be specifying react and react-dom as dependencies they are installed also which shouldn't be the case. Please change them to peerDependencies.
@bluebill1049
Copy link
Member

Thanks! good pick up, i will sort this out over the weekend with react 16 upgrade for the project. many thanks ❤️

@bogdansoare
Copy link
Author

Cool. Thank you for all the work on this library ❤️

@bluebill1049
Copy link
Member

Thank you again for your report. This have been resolved now with testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bogdansoare @bluebill1049