-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for style objects in AnimateKeyframes #57
Comments
hi @stroborobo, I can definitely support object syntax which aligns with for |
hey @pangpang1987, Did you have the capacity to convert object into a string for AnimateKeyFrames? basically, support
currently, we support only string:
|
Object.entries? Absolutely, |
haha no worries @stroborobo , either @pangpang1987 or I will work on that feature. |
@bluebill1049 I can work on this. Keep the styles object. |
thanks, heaps @pangpang1987 legend. |
Do you want to reimplement the two step senerario to use from to? Or keep the existing one? |
i think it's better to support both, then it's not a breaking change @pangpang1987 |
@pangpang1987 I have tested the feature branch works great 👍 however this is not working I will publish what you got with a minor update first, we can patch in the next release |
Looks like the above use is low. Going to close it for now |
Is your feature request related to a problem? Please describe.
The API to define styles is different in
AnimateKeyframes
compared toAnimate
. WhileAnimate
supports an object with key/value as styles,AnimateKeyframes
only seems to support a string, making it harder to compute and manipulate.Describe the solution you'd like
It would be nice if
AnimateKeyframes
would support the style object, too.Perhaps keyframes could look like this:
Additional context
Putting the animation index (%) into a property instead of being the object key itself would help interoperability from other languages that compile to JS, but aren't as dynamic.
The text was updated successfully, but these errors were encountered: