Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using webp images with <picture> and multiple source sets? #72

Closed
andreimc opened this issue Aug 4, 2019 · 2 comments
Closed

Using webp images with <picture> and multiple source sets? #72

andreimc opened this issue Aug 4, 2019 · 2 comments

Comments

@andreimc
Copy link

andreimc commented Aug 4, 2019

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I would like to use react-simple image with webp as well: eg https://responsivedesign.is/articles/adding-webp-images-progressively/

Describe the solution you'd like
A clear and concise description of what you want to happen.

  <picture>
    <source type="image/webp"
            srcset="images/worlds-300.webp 300w,
                    images/worlds-600.webp 600w,
                    images/worlds-800.webp 800w,
                    images/worlds.webp 1000w"
             />
    <source srcset="images/worlds-300.jpg 300w,
                    images/worlds-600.jpg 600w,
                    images/worlds-800.jpg 800w,
                    images/worlds.jpg 1000w"
            />
    <img src="images/worlds-300.jpg"
    alt="The Speed of Light and the Timing of Eclipses" />
  </picture>

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@bluebill1049
Copy link
Member

Good suggestion, but I will start to work on that when img src tag support webp. Otherwise, it's a massive change inside the codebase to adopt element.

@bluebill1049
Copy link
Member

going to close this for now. until img src tag support webp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants