Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: SQL Formatter is improved and has multiple formatting options #1504

Open
rathboma opened this issue Feb 17, 2023 · 0 comments
Open

FEAT: SQL Formatter is improved and has multiple formatting options #1504

rathboma opened this issue Feb 17, 2023 · 0 comments
Labels
accepted 👍 enhancement New feature or request

Comments

@rathboma
Copy link
Collaborator

rathboma commented Feb 17, 2023

The SQL formatter is a big part of the SQL editing experience, so we need to make it a lot better. This is the type of rough-edge that puts people off from using the app.

This is an issue of several parts:

Fix existing issues

Add a more sensible default

The default formatting should probably be more compact, and likely follow the prettifier package on how that formats SQL

Add new options

Right now we only support one option Format Query, we should provide a bunch of 'styles' that users can use to indent their code.

Styles:

  • Default
  • Vertical compact

This can be based on indent styles provided by the library:

https://github.com/sql-formatter-org/sql-formatter#configuration-options

But whoever implements this should be sure that they think sensible indentation styles to their liking are covered by this functionality.

Feedback on specific formatting options

@rathboma rathboma added enhancement New feature or request accepted 👍 labels Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted 👍 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant