'make install' does not install to CMAKE_INSTALL_PREFIX

[Beep6581]

Originally reported on Google Code with ID 30

I think that the actual CMakeList.txt target a specific src/../release
directory instead of respecting CMAKE_INSTALL_PREFIX, as I would expect
from code built with cmake.

I was testing this with r25.

Thank you,
Lluís.

Reported by viriketo on 2010-01-17 17:12:34

[Beep6581]

Attaching patches for

1. making rtengine static library as I don't see a single reason why it should be
shared one

2. Make rt work in FHS compliant mode for system wide installation. This mode is
default on non Windows builds, but can be still turned off in case you want to
produce standalone binary package.

Reported by michal@cihar.com on 2010-01-18 13:07:21

---

- _Attachment: [0003-Make-rtengine-static-library.patch](https://storage.googleapis.com/google-code-attachments/rawtherapee/issue-30/comment-1/0003-Make-rtengine-static-library.patch)_

[Beep6581]

Updated patch with forgotten config.h.in.

Reported by michal@cihar.com on 2010-01-18 14:06:31

---

- _Attachment: [0004-Add-support-for-FHS-compliant-system-wide-install.patch](https://storage.googleapis.com/google-code-attachments/rawtherapee/issue-30/comment-2/0004-Add-support-for-FHS-compliant-system-wide-install.patch)_

[Beep6581]

Thank you!
Btw,  for me it is fine if you commit those patches, instead of adding them here
apart, and here you simply write the release number. In any case, I'm building svn
sources, not from the targz of 3.0.

Reported by viriketo on 2010-01-18 14:14:11

[Beep6581]

I don't have commit access, that's why I'm just posting patches :-).

Reported by michal@cihar.com on 2010-01-18 14:18:19

[Beep6581]

I think you should have. Wold be great have this patch in trunk.

Reported by Marian.Kyral on 2010-01-24 13:59:11

[Beep6581]

Could you submit the patch again against the current revision, please? I would like
to apply it. I really appreciate your contribution. 

Reported by ghorvath.x on 2010-01-31 20:31:31

[Beep6581]

Attaching all current patches from my tree.

Reported by michal@cihar.com on 2010-02-01 08:38:54

---

- _Attachment: [rt-patches.tar.bz2](https://storage.googleapis.com/google-code-attachments/rawtherapee/issue-30/comment-7/rt-patches.tar.bz2)_

[Beep6581]

xnijel;

We are now getting the infrastructure and procedures in place to better accept third
party patches.  We thank you very much for your patch submissions earlier, and
apologize that we have not yet been able to implement them.  If it is not too much
trouble, would you be able to re-generate this and the other patches based on the
current trunk?  There have been a number of changes, especially to the build system,
and I am not confident enough with CMake to merge these files manually.

Let me know if you have any questions.

Cheers

Reported by wyatt.olson on 2010-04-22 13:56:53

[Beep6581]

I currently don't have time for this, but I will try to find time to check whether my
patches would be still needed 
or not.

Reported by michal@cihar.com on 2010-04-22 14:27:39

[Beep6581]

That would be wonderful, thank you very much!

Cheers

Reported by wyatt.olson on 2010-04-22 14:49:43

[Beep6581]

Issue 35 has been merged into this issue.

Reported by wyatt.olson on 2010-04-24 17:33:49

[Beep6581]

Issue 24 has been merged into this issue.

Reported by wyatt.olson on 2010-04-24 17:34:05

[Beep6581]

This is solved, isnt it?

Reported by iliaworld@yandex.ru on 2010-04-24 20:51:23

[Beep6581]

Not sure; I know there was a complete overhaul of the cmake system, but I am not sure
how it is working on Linux at the moment.  I know for Windows and OSX we (correctly)
install by default into a release/ folder within the source tree so that we can
bundle things, but Linux is different I believe.

If someone running Linux can verify this, that would be great and I can close this
ticket.

Cheers

Reported by wyatt.olson on 2010-04-24 21:21:01

[Beep6581]

Yes, I am using this under linux (Ubuntu 9.10).

I do
cmake -DCMAKE_INSTALL_PREFIX=./release -DBINDIR=. -DDATADIR=. -DLIBDIR=. .

and after that make install installs everything to release dir

If i do just
cmake .

it installs to system dirs. This is considered right behavior

Reported by iliaworld@yandex.ru on 2010-04-24 21:33:40

[Beep6581]

Good enough for me.  If anyone else notices a problem here, please let me know;
otherwise I will consider this fixed.

Cheers

Reported by wyatt.olson on 2010-04-24 21:39:31

• Status changed: Fixed