Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for Garden connection during plugin creation #758

Closed
hazmat345 opened this issue Nov 23, 2020 · 1 comment
Closed

Wait for Garden connection during plugin creation #758

hazmat345 opened this issue Nov 23, 2020 · 1 comment
Labels
brewtils Work required in the brewtils repository feature New feature or request needs details Issue lacks details needed to proceed. Investigation may be required

Comments

@hazmat345
Copy link
Contributor

Should we be blocking during Plugin creation until the Beer-garden connection is successful? Consequence of not doing this is that any SystemClients that are expecting the namespace to be correct may not actually be.

We could also just raise if the connection fails. I'd prefer not to do that, though.
@hazmat345 hazmat345 added the brewtils Work required in the brewtils repository label Nov 23, 2020
@hazmat345 hazmat345 added feature New feature or request needs details Issue lacks details needed to proceed. Investigation may be required labels Jul 13, 2021
@TheBurchLog
Copy link
Contributor

Plugins are now required to connect and if it doesn't then the plugin fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brewtils Work required in the brewtils repository feature New feature or request needs details Issue lacks details needed to proceed. Investigation may be required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBurchLog @hazmat345