Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search header tag inside page header #188

Closed
laurentpayot opened this issue Jul 21, 2023 · 0 comments
Closed

Search header tag inside page header #188

laurentpayot opened this issue Jul 21, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request next release Available in the next release

Comments

@laurentpayot
Copy link
Collaborator

Beercss search requires a header tag, docked or fullscreen.

That’s a problem because if you want to put a search input in your app bar you will end up with the header tag of the search inside the header tag of the app bar (the page header). You should not do that according the the HTML standard specifications for the header tag:

Content model:
Flow content, but with no header or footer element descendants.

An example here: https://codepen.io/laurentpayot/pen/JjeZLJx

So is the header tag really necessary for Beercss search?
Could we replace it by a section tag or an aside tag? Or even a div tag with a special class?

@laurentpayot laurentpayot changed the title Search <header> tag inside page header Search header tag inside page header Jul 21, 2023
@leonardorafael leonardorafael self-assigned this Jul 27, 2023
@leonardorafael leonardorafael added enhancement New feature or request next release Available in the next release labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next release Available in the next release
Projects
None yet
Development

No branches or pull requests

2 participants