Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<menu> and <li> better alignment with HTML spec? #240

Closed
edwindj opened this issue Nov 18, 2023 · 3 comments
Closed

<menu> and <li> better alignment with HTML spec? #240

edwindj opened this issue Nov 18, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request next release Available in the next release

Comments

@edwindj
Copy link

edwindj commented Nov 18, 2023

One of the attractive features for beercss is that it stays very close to clean HTML.
In general the resulting html is very clean, and beercss styles with a minimal intrusion of class attributes.

Menu's in beercss are very nice. I was wondering if it wouldn't be better if the HTML standard was followed, in which the menu items are <li> elements. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu
Current practice seems to use <a class="row"> as items, which works fine, but is non-standard html.

@laurentpayot
Copy link
Collaborator

I also think that replacing sequences of links by <ul> lists would be nice. For <menu> but also for <nav> and everywhere else actually. When I was using Spectre that’s the way it was implemented.
But I don’t know how much it would impact the size of the bundle, in a bad or a good way...

@leonardorafael
Copy link
Collaborator

We will try to add this on next release, we need to go back to 10 kb (current it's 11 kb)
It's a big challenge.
I will put the next release label to work on it.

@leonardorafael leonardorafael self-assigned this Nov 22, 2023
@leonardorafael leonardorafael added enhancement New feature or request next release Available in the next release and removed next release Available in the next release labels Nov 22, 2023
@leonardorafael leonardorafael added the next release Available in the next release label Dec 7, 2023
@leonardorafael
Copy link
Collaborator

Hi, the next release we will add support to ol, ul, li inside nav and menu. And the minimalist version of nav and menu will still there.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/nav
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu
https://www.w3schools.com/tags/tag_menu.asp
https://www.w3schools.com/tags/tag_nav.asp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next release Available in the next release
Projects
None yet
Development

No branches or pull requests

3 participants