You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
I was wondering if there is the possibility to add to the check something like
pip list --outdated
and fail the check if new packages have been updated. Maybe we need some kind of flexibility, so we want to pass a certain amount of packages with versions that could be skipped?
Just a thoughts.
The text was updated successfully, but these errors were encountered:
Definitely sounds like an interesting idea that is worth having at some level.
However, I'm not sure if this is appropriate as a pre-review check, or a pre-commit check. For example: You submit a patch that adds feature X or fixes bug Y; BeeFore runs and raises an error because package Z needs to be updated. The fact that package Z needs to be updated is (probably) unrelated to the X or Y, and from a change management point of view, any fixes required by updating Z shouldn't be included in the same commit as the X/Y PR.
This is definitely something that should be reported, though - a simple lack of awareness that dependencies have updates pending is worth flagging. In fact, whenever a dependency is updated, the test suite should be executed again to verify that the code still works - if it doesn't, a bug should be opened to either constrain the version dependency, or update the code to handle the change.
TBH I would like to have the run in any commit, as part of my test-suite. If there is a PR, and the dependencies are not up to date, it would be cool to have something that:
branch off master
update the requirements to latest
test suite runs automatically
propose PR
Maybe a service that check this stuff would be good, but as a start it could be done just before the test-suite, or whenever beefore would be ran.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I was wondering if there is the possibility to add to the check something like
and fail the check if new packages have been updated. Maybe we need some kind of flexibility, so we want to pass a certain amount of packages with versions that could be skipped?
Just a thoughts.
The text was updated successfully, but these errors were encountered: