-
-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to using WiX 4 #1185
Comments
Figured this would be an easy win....but it's a bit more involved. Here are some notes I made. WiX 4
So, it seems this affects pretty much anything that could've been affected 🙃 I also think this means supporting both version 3 and 4 of WiX concurrently would be prohibitive....not that we'd necessarily want to... |
Thanks for that audit - a list of annoying changes, to be sure; but nothing that sounds like an unsurmountable challenge. In terms of supporting both - unless there's a feature of WiX 3 that WiX 4 doesn't (or won't) support, I don't think we need to support both. WiX 3 has at least 2 major missing features (>64 char path name support, and ARM64 support); so IMHO we should migrate as soon as practical. |
I made an attempt at this upgrade....but I think the gap in my knowledge about where and how WiX is expecting to fit in to a larger Windows development and packaging workflow is too large. I converted the WiX files provided by the app template in beeware/briefcase-windows-app-template#14; there are likely some necessary tweaks and optimizations but that should be most of the work. When I focused my attention on updating the calls to At any rate, I thought I could power through and figure it out relatively quickly....but I don't think so. I may return to this later if someone else doesn't knock it out. |
Good to know WiX is maintaining its long tradition of near useless documentation... 🙄 |
FYI; looks like WiX is moving to an annual release schedule. https://www.firegiant.com/blog/2024/3/8/wix-v5.0.0-rc.1-is-calling/ |
Ugh... we really do need to address this so we don't get stuck on v3 forever... |
What is the problem or limitation you are having?
Windows packaging currently uses WiX Toolset 3. This version of WiX has a known issue with long file paths (#948), as well as no support for ARM64.
Describe the solution you'd like
Briefcase should be updated to use WiX 4.
Describe alternatives you've considered
Stay on WiX 3.
Additional context
WiX 4 release details.
It is unclear how much the format for WiX configuration files has changed - this could be as straightforward as changing the path to the WiX binary that is downloaded.
The text was updated successfully, but these errors were encountered: