Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture logging for tools using stdlib logging #1529

Merged
merged 1 commit into from Nov 8, 2023
Merged

Capture logging for tools using stdlib logging #1529

merged 1 commit into from Nov 8, 2023

Conversation

rmartin16
Copy link
Member

Changes

  • This generalizes support for tools that log using the stdlib logging introduced in Enable debug cookiecutter logging for deep debug #1470
  • Now, both logging for cookiecutter and GitPython are supported
  • This also ensures that such logging is captured in the logfile and is dimmed in the console...which is nice

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delightfully elegant - nice!

@freakboy3742 freakboy3742 merged commit 4862d70 into beeware:main Nov 8, 2023
35 checks passed
@rmartin16 rmartin16 deleted the support-stdlib-logging branch November 8, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmartin16 @freakboy3742