You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When using Docker, only the briefcase create command supports creating the image to create containers to run commands. If this docker image is deleted, commands other than create fail to run.
Describe the solution you'd like
Anytime a command needs to run thru Docker, create the image if it doesn't exist.
As for an implementation, this may be as simple as calling docker.prepare() before issuing any commands via docker run. Although, that'll invoke running thru the entire Dockerfile again....perhaps a docker image call would be sufficient.
Describe alternatives you've considered
Re-run the briefcase create command to create the Docker image.
The text was updated successfully, but these errors were encountered:
+1 - I've hit this one a few times in testing #756, but I was doing enough weird stuff there that it didn't hit my internal threshold of "dammit, I need to fix this, don't I". :-)
I think you're right about the general approach - Docker builds are pretty heavily cached and optimised for the "no change" case, so the overhead of calling Docker "unnecessarily" is fairly low. We don't want to call build before every call to docker.run() - but once per app at the start of a call to briefcase build would definitely be warranted.
Is your feature request related to a problem? Please describe.
When using Docker, only the
briefcase create
command supports creating the image to create containers to run commands. If this docker image is deleted, commands other thancreate
fail to run.Error example
Describe the solution you'd like
Anytime a command needs to run thru Docker, create the image if it doesn't exist.
As for an implementation, this may be as simple as calling
docker.prepare()
before issuing any commands viadocker run
. Although, that'll invoke running thru the entire Dockerfile again....perhaps adocker image
call would be sufficient.Describe alternatives you've considered
Re-run the
briefcase create
command to create the Docker image.The text was updated successfully, but these errors were encountered: