Enforce object type for weak properties #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samschott
force-pushed
the
enforce-object-type-for-weak-properties
branch
from
75794f1
to
4afea92
Compare
dgelessus
reviewed
Aug 16, 2021
dgelessus
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces that the vartype of weak properties must be map to
objc_idorpy_object, i.e., that the property has an object type. This is because creating and storing weak reference in Objective-C is only supported for object types.If a weak property is declared with a primitive C type or anything that maps to a primitive ctype, setting the value will succeed without an error but retrieving the value will return something entirely different.
PR Checklist: