Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct value of MultilineTextInput.readonly for iOS. #1866

Closed
wants to merge 3 commits into from

Conversation

o-fedorov
Copy link
Contributor

@o-fedorov o-fedorov commented Apr 13, 2023

On iOS, MultilineTextInput is read-only by default and when readonly is False, and editable when readonly is True.

Fixes #1859

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Signed-off-by: Oleksandr Fedorov <o-fedorov@users.noreply.github.com>
@o-fedorov
Copy link
Contributor Author

I would appreciate if you suggest how to add tests for this change.

@freakboy3742
Copy link
Member

@o-fedorov This is an area where our docs are a bit slim, so I've just added a PR (#1868) to add details on how the testbed app and backend tests work. You can see a preview of these docs here.

At present, there aren't any backend tests for MultilineTextInput, so any improvement here will be a win. If those docs don't make any sense, or you can't work out how to build a test for readonly, let us know - we can merge what you've got here so you're unstuck on the specific bug. We're in the process of auditing all the widgets, so we should be adding tests fairly soon.

@o-fedorov
Copy link
Contributor Author

@freakboy3742 thank you for the response. I have created a copy of this PR with tests added: #1869

Feel free to do anything with these PRs, like close this one and update the other PR.

@freakboy3742
Copy link
Member

Thanks - I'll close this in favour of #1869, since that looks pretty close to being merge ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

readonly value of MultilineTextInput for iOS is inverted
2 participants