Fixed pixbuf bug in gtk icons. #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proneon267
force-pushed
the
patch-16
branch
from
e286ef6
to
9bf1543
Compare
freakboy3742
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Thanks for the fix. This likely would have been picked up by the tests on #2075 when it is fully merged up with the changes to toga.Icon that have landed in main, but it doesn't hurt to get ahead of things.
However, for future reference - "Fixes the bug" isn't a very helpful description. Which bug? How does it manifest? How can I verify that this patch fixes the bug? In this case, it's reasonably obvious that you can trigger the bug by opening the About menu, but as a general rule, if a PR isn't associated with an issue, including reproduction or testing instructions is a fairly important part of a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a pixbuf bug present in gtk icons. Prevents the error:
With this bug, it would be impossible to show the about dialog on gtk.
PR Checklist: