Winforms and Android Canvas fixes #2184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue we were talking about with the miter does also happen with the native WinForms arc method, but only when the arc is less than a full circle. When you ask for a full circle, it automatically closes the path, which the HTML spec specifically says not to do. So this fixes that bug as well. |
4 tasks
freakboy3742
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
I don't understand it, so it must be art. 😝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both WinForms and Android had issues with elliptical arcs being disconnected from adjacent segments of the same path. This PR fixes both platforms using the same method -- converting the arc to a series of Bezier segments.
Also fixes an issue on WinForms with keyboard shortcuts, which was exposed by examples/canvas.