Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to explicitly list gradle dependencies. #2363

Merged
merged 3 commits into from Jan 31, 2024

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Jan 25, 2024

With the introduction of beeware/briefcase#1610, the Toga examples need to explicitly list their gradle dependencies to avoid a warning at time of build.

The testbed and hardware app have been updated as part of #2350.

Testing the hardware app revealed that there is a discrepancy between the explicitly declared App ID and the app ID constructed from the bundle and app name; I've used this opportunity to normalise all the examples into an org.beeware.toga.examples namespace.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@mhsmith mhsmith merged commit f52598c into beeware:main Jan 31, 2024
35 checks passed
@freakboy3742 freakboy3742 deleted the examples-update branch January 31, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants