-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renderOnScroll causing bug #77
Comments
Sorry for delay in noticing this. Working on a fix right away. |
@Jaaneek I was not able to reproduce this, can you provide me with more details, please?
|
Error appears after some moment, the list is not empty but after providing searchTerm that doesnt match any of the elements it doesnt show anything just as supposed. It shouldnt show error because of that right? |
No you are correct. Ill retests using the cocktail of options as you have them and get back to you. |
Seems like this issue was fixed in this commit: in release 1.5.0 I will keep this issue opened until the next release and let you know about it. Thank you [details of the bug] |
FlatList Version
:1.4.3
Describe the bug
: Enabling renderOnScroll throws error when searchTerm doesnt match any elements
Steps to reproduce the behavior
:
Set renderOnScroll to true
search props:
Render around 400 elements.
set searchTerm to something like "8218132873873nrui3" so that it wont match anything.
set searchTerm to something that will match a few elements.
Expected behavior
:after a short moment error will appear: TypeError: Cannot set property 'scrollTop' of null
Desktop (please complete the following information):
Smartphone (please complete the following information):
Screenshots
![image](https://user-images.githubusercontent.com/25470423/102610703-ea968980-412d-11eb-850c-57882cd0a7ac.png)
![image](https://user-images.githubusercontent.com/25470423/102610742-fd10c300-412d-11eb-8c4b-5aa65f4ccc25.png)
![image](https://user-images.githubusercontent.com/25470423/102610729-f5e9b500-412d-11eb-8cda-bb4e49604941.png)
The text was updated successfully, but these errors were encountered: