Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make sure the generated page is valid xml #33

Closed
modehnal opened this issue Feb 13, 2023 · 4 comments
Closed

Try to make sure the generated page is valid xml #33

modehnal opened this issue Feb 13, 2023 · 4 comments
Milestone

Comments

@modehnal
Copy link
Collaborator

xml validator seems to have issues with the generated page. Try to look into it.

There is a use case where someone might want to load the page with xml parser.

@fpokryvk
Copy link
Collaborator

fpokryvk commented Feb 27, 2023

I would suspect pretty_output=False option, but I will investigate further.

Copy link
Collaborator Author

Test Slack Comment

@fpokryvk
Copy link
Collaborator

fpokryvk commented Oct 10, 2023

I have checked python lxml module, it indeed can't parse the file as xml, throwing error at weird position (somewhere in the middle of minified javascript with pretty_output=False), however, lxml.html module works fine even with condensed output. Or did you have some more specific issues in mind? @modehnal Is this safe to close?

@modehnal
Copy link
Collaborator Author

We can close this. I believe this issue was raised by our colleague who wanted it for some specific use case that was solved or is not needed anymore, I am not sure now it was quite some time back.

@modehnal modehnal added this to the Q4@23 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants