Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable antd components. #50

Open
lokeshrana9999 opened this issue Jun 12, 2020 · 2 comments
Open

Reusable antd components. #50

lokeshrana9999 opened this issue Jun 12, 2020 · 2 comments
Assignees

Comments

@lokeshrana9999
Copy link
Collaborator

Currently look module contains a reusable iteration of antd components but not all of them.

Steps-

  • Choose the correct version.
    Antd
  • See if component is already there.
    • If Not:
      • Create a new file following existing naming convention.
      • Write the component code like this Code
      • Add the proptypes using this part of the antd component page.
        Button - Ant Design
      • Update export in index.js file
    • If component already present.
      • Update the proptypes.

Ps leave out the data entry section of the antd components for now.

@lokeshrana9999
Copy link
Collaborator Author

Comment here for any doubts

@beingtmk
Copy link
Owner

beingtmk commented Aug 14, 2020

  1. create "actions" folder in "ui-antd/components"
  2. add 2 buttons for each action i.e (circular button with only icon) & (rectangular button with icon & text)
  3. create a demo page "demo/actions" - where all components are displayed & console.logs when clicked (onClick function should be passed from outside.)
  4. Btns with text will have default text but can be overided if "text" prop is passed.
  5. Define the proptypes in the respective components.
  • add
  • edit
  • view
  • delete (will have pop-confirm)
  • next
  • submit (will have pop-confirm, but will be configurable i.e. default false but show if "confirm=true" prop is passed)
  • remove (minus icon) (will have pop-confirm, but will be configurable i.e. default false but show if "confirm=true" prop is passed)
  • activate / deactivate (will have pop-confirm)
  • publish / disable (will have pop-confirm)

@r-kohale9, @ishanajmeri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants