Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in beir/beir/retrieval/search/sparse/sparse_search.py #60

Open
jin530 opened this issue Jan 24, 2022 · 1 comment
Open

Error in beir/beir/retrieval/search/sparse/sparse_search.py #60

jin530 opened this issue Jan 24, 2022 · 1 comment

Comments

@jin530
Copy link

jin530 commented Jan 24, 2022

https://github.com/UKPLab/beir/blob/568f4c34fa0be1901e2aaa8479978c9e54a1e377/beir/retrieval/search/sparse/sparse_search.py#L28-L34

Hello,

I think there is an error in sparse_search.py; only the first query in each batch is evaluated.

Thank you!
@maximedb
Copy link
Contributor

maximedb commented Feb 9, 2022

Indeed! An easy fix would be to remove the step size self.batch_size?

@maximedb maximedb mentioned this issue Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximedb @jin530