Allows single node Raft to apply entries #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pass majority to RequestTable on creation to commit entries immediately if possible - check if entry is committed after setting it on the leader and apply it immediately if so
|
Hey Nicolas |
|
Thanks for the quick reply! This would solve #69 yes. |
|
OK, so I applied your PR (with minor, mainly cosmetic, changes). |
|
Ah, you can remove it, I'm sorry that was a left over from an initial approach. Sorry about that Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #69
Note: as mentioned in #69, by using the leader's vote, we could allow the log entries to be appended asynchronously and once finished add the vote to the request table.
One small thing, I would have preferred that applying the entry is done after we return the future in
setAsync, but I didn't see any facilities for this. I know some Raft implementations will sometimes decouple the state machine and the Raft itself in different execution contexts, such that applying is also done asynchronously; this has some other issues (i.e. buffering apply calls), but could be an approach.