Fix CTCP parsing to avoid segfault #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djt-code
force-pushed
the
fix-ctcp-parse
branch
from
ed87da3
to
7da4007
Compare
belak
requested changes
Dec 19, 2016
| if len(lastArg) > 1 && lastArg[0] == '\x01' && | ||
| lastArg[len(lastArg)-1] == '\x01' { | ||
| m.Command = "CTCP" | ||
| m.Params[len(m.Params)-1] = strings.Trim(lastArg, "\x01") |
There was a problem hiding this comment.
I'd rather just trim off the first and last character.
|
Done! |
belak
approved these changes
Dec 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a check for the LastIndex was just ensuring that there WAS a \x01 in the message, and not that the Last character in the string was a \x01