Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes on parameters #204

Closed
belav opened this issue May 17, 2021 · 1 comment · Fixed by #333
Closed

Attributes on parameters #204

belav opened this issue May 17, 2021 · 1 comment · Fixed by #333
Assignees
Labels
area:formatting type:bug Something isn't working
Milestone

Comments

@belav
Copy link
Owner

belav commented May 17, 2021

Currently when a method has parameters with attributes it looks like

    public void MethodName(
        int someParameter,
        [LongAttributeName(SomeFlag.SomeValue)]
        AnotherObject anotherObject,
        string anotherValue
    ) {
        return;
    }

Which makes it a little hard to tell where the parameters are.
We could do something like below

    public void MethodName(
        int someParameter,
        [ShortAttribute] AnotherObject anotherObject,
        string anotherValue
    ) {
        return;
    }

    public void MethodName(
        int someParameter,
        [LongAttributeName(SomeFlag.SomeValue, "MoreStuffToMakeThisLong")]
            AnotherObject anotherObject,
        string anotherValue
    ) {
        return;
    }
@belav belav added type:bug Something isn't working area:formatting labels May 17, 2021
@brikabrak
Copy link
Contributor

Until formally assigned, I'll start looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:formatting type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants