Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require the directoryOrFile argument when not piping into to stdin #381

Closed
Tracked by #341
belav opened this issue Jul 28, 2021 · 1 comment · Fixed by #388
Closed
Tracked by #341

Require the directoryOrFile argument when not piping into to stdin #381

belav opened this issue Jul 28, 2021 · 1 comment · Fixed by #388
Assignees
Milestone

Comments

@belav
Copy link
Owner

belav commented Jul 28, 2021

The --check option is not longer reporting missing files when used inside of a github action.

This was most likely caused by the changes for #282
Going back to 0.9.4, the current github action will fail a build for unformatted files.
As of 0.9.8 it definitely does not.
#282 came out in 0.9.6

After resolving this bug, also add a step to the ValidatePR that tests --check to ensure we don't break this again.

@belav belav added type:bug Something isn't working priority:high area:cli labels Jul 28, 2021
@belav belav self-assigned this Aug 3, 2021
@belav belav changed the title --check inside a github action is no longer reporting/failing workflows Require the directoryOrFile argument when not piping into to stdin Aug 3, 2021
@belav
Copy link
Owner Author

belav commented Aug 3, 2021

When introducing the ability to read from stdin, a bug was introduced that caused --check to not work when run inside a github action.
One fix for this is requiring that directoryOrFile is supplied if not piping to stdin.
CSharpier can then read from stdin if stdin is redirected and directoryOrFile is not supplied. During a github action, stdin is redirected.
CSharpier will now fail to run if directoryOrFile is not supplied, which is a breaking change.

@belav belav mentioned this issue Aug 3, 2021
10 tasks
@belav belav added this to the 0.9.9 milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant