Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEARCH: drop the search API #104

Closed
jacoscaz opened this issue Sep 17, 2020 · 5 comments · Fixed by #107
Closed

SEARCH: drop the search API #104

jacoscaz opened this issue Sep 17, 2020 · 5 comments · Fixed by #107

Comments

@jacoscaz
Copy link
Owner

Assuming we choose to follow through with #103, the SEARCH API would become a redundant, less-powerful alternative to the SPARQL API. It wouldn't make sense to keep it around.

@jacoscaz jacoscaz added this to the v7.0.0 - Advanced searches, basic SPARQL queries milestone Sep 17, 2020
@gsvarovsky
Copy link
Contributor

Actually the search API might be very useful to me.

The reason is, my project has a json-rql interface. It looks like it would be better for me to use your search API directly, rather than translating first to SPARQL.

I will try to investigate as soon as possible. When do you anticipate doing this work?

@jacoscaz
Copy link
Owner Author

@gsvarovsky interesting! I'm still brainstorming on this and I am really happy to get some community feedback.

Consider that the work on the SPARQL API will bring support for SPARQL queries expressed both as SPARQL strings and as SPARQL Algebra objects (see https://www.npmjs.com/package/sparqlalgebrajs). From the looks of it, converting a JSON RQL query to a SPARQL Algebra object should not be any more difficult than converting the same query to use with quadstore's Search API.

What do you think? I would otherwise be happy to figure out how to keep the search API around.

@gsvarovsky
Copy link
Contributor

You are right, using the algebra will be just as good as the current search API, probably even better. Thanks!

@jacoscaz
Copy link
Owner Author

No worries! Thank you for mentioning JSON RQL, I wasn't aware of it. I will come back to this issue in a while, once work on SPARQL continues.

@jacoscaz jacoscaz changed the title SEARCH: evaluate whether to drop the search API SEARCH: drop the search API Oct 10, 2020
jacoscaz added a commit that referenced this issue Oct 18, 2020
…5), drops the search API (closes #104), fixes exact match to numeric literals (closes #106)
@jacoscaz
Copy link
Owner Author

jacoscaz commented Oct 18, 2020

Released on NPM - quadstore@7.0.1-alpha.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants