-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#119: Key-value interface: optional pre-write #120
Conversation
This seems quite good to me already. I'll just leave a couple of nitpick-y comments. How would you handle reading those custom entries? The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my comments:
- a mention to these hooks in
README.md
- a dedicated test file for these hooks, with one unit test per each hook, preferably using
quadstore.db.get()
to verify writes
After that I think we should be all set for a new beta.
I agree – just use the |
I propose that I try this new interface in m-ld, to see if it solves my problem neatly, before we commit to it. It will mean a bit of a delay. Or are you really keen to get the Beta out? |
I think this is a really nice and useful PR that complements having direct access to the I am not in a rush, so it’s really up to you, but I would still like to merge this on its own merit when it’s ready. |
@gsvarovsky fantastic work - do you require a beta right away? |
Great! Not right away. In the next few days would be great, I have one more optimisation in m-ld to work on before I do another pre-release myself. |
All right, feel free to ping me anytime about it. Also, how did you find hacking on |
A lot more fun than doing the market research I've been putting off... It's a great project, you should be proud! |
Here is a simple proposal for the key-value interface discussed in #119 .
On the basis that the creator of the quadstore already has access to the raw backend, this proposal does not try to prevent:
write
orclear
.Happy to discuss and add tests/docs when ready.