Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade info totally broken #41

Closed
damntoken opened this issue Dec 8, 2018 · 2 comments
Closed

Trade info totally broken #41

damntoken opened this issue Dec 8, 2018 · 2 comments

Comments

@damntoken
Copy link

https://www.kraken.com/help/api#get-recent-trades
States in one ecample 'since' => '137589964200000000'));
Since is a 18 place string timestamp, not 10.
krakenapi.fo file has:
values.Set("since", strconv.FormatInt(since, 10))
Should be to 18, not 10.. or response has times offset by years.

Also beware kraken api docs state:
NOTE: the 'since' parameter is subject to change in the future: it's precision may be modified, and it may no longer be representative of a timestamp. The best practice is to base it on the 'last' value returned in the result set.

@beldur
Copy link
Owner

beldur commented Dec 8, 2018

Hi damntoken,

thanks for the input. Could you create a Pull request with an appropriate fix?

@gadfly16
Copy link

gadfly16 commented May 9, 2020

Hi, I think it's utter nonsense and should be closed as such. The second argument of strconv.FormatInt is the base that you want to convert to.

@beldur beldur closed this as completed May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants