Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return only 'stream' claims when searching claims in a channel #13

Open
belikor opened this issue Feb 21, 2022 · 0 comments
Open

Return only 'stream' claims when searching claims in a channel #13

belikor opened this issue Feb 21, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@belikor
Copy link
Owner

belikor commented Feb 21, 2022

Various operations such as download and delete can only be performed on downloadable content, that is, streams.

At the moment many functions depend on searching multiple claims from a channel by using search_ch.ch_search_latest.

Instead of returning all types (streams, reposts, collections, livestreams) from the search, we should add an option to only return streams:

claims = ch_search_latest("@some-chn", number=12, only_streams=False)
streams = ch_search_latest("@some-chn", number=12, only_streams=True)

This can be implemented by specifying the claim_type and using the has_source parameter in claim_search in lbrynet:

lbrynet claim search --channel=@some-chn --claim_type=stream --has_source=True

Livestreams are of type 'stream' but they don't have a source, so they are not downloadable, and should be avoided.

@belikor belikor added the enhancement New feature or request label Feb 21, 2022
@belikor belikor added the help wanted Extra attention is needed label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant