Arc Control Bugs

[BelleNottelling]

This issue is just so I can track issues / bugs within Arc Control.
Current bug count: 2

applyPerformanceTuning does not update performance sliders

The applyPerformanceTuning function does not correctly update the performance tuning sliders with the data that is returned by the back-end. Resulting in an OC seemingly applying, but not actually doing so.

Fix

        if (ret?.success) {
            document.getElementById('performance-restore').classList.add(isDisabled);
            newTuningSettings = null; // reset the state so we can make more changes
            updateOverclockingSettings(ret?.data);
+           updatePerformanceTuningSettings();
            warningRequired = false; // clear warning flag
            document.getElementById('performance-unstable-configuration-container').classList?.toggle(isHidden, true);
        }

Game details page doesn't use fallback image

Two issues:

1. The usage of a flawed check to see if the game has an icon (gameAsset == null || gameAsset == "";, this will never be null or an empty string)
2. For some reason, the onerror property doesn't seem to work correctly on that page, although I'm unsure as to why