Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one integration mode for the IonOptix Integration #3

Open
NiekWe opened this issue Mar 8, 2023 · 9 comments · Fixed by #9
Open

Only one integration mode for the IonOptix Integration #3

NiekWe opened this issue Mar 8, 2023 · 9 comments · Fixed by #9
Assignees
Labels
Change requested Changes (which are not a bug or enhancement)

Comments

@NiekWe
Copy link
Collaborator

NiekWe commented Mar 8, 2023

⚠️ This is a issue tracker ⚠️

remove all operational modes except "standard and regular" for the IonOptix integration

Your Environment

  • Operating System and version:all
  • Compiler:
  • Labonatip Version:1.1.5

Expected Behavior

Only one operational mode left

Current Behavior

4 different operational modes, for UWZ only one operational mode needed.

Possible Solution

image5701

@NiekWe NiekWe added enhancement New feature or request Change requested Changes (which are not a bug or enhancement) and removed enhancement New feature or request labels Mar 8, 2023
@bellonemauro bellonemauro self-assigned this Mar 10, 2023
@bellonemauro
Copy link
Owner

bellonemauro commented Mar 10, 2023

This sounds kind of weird in my perspective. If there is only one OM, then nothing would be needed there so we could keep it clean. The same is in the case of biopen (no operational modes are available there). What do you think if we just remove/hide/gray it out?

@bellonemauro bellonemauro linked a pull request Mar 10, 2023 that will close this issue
@NiekWe
Copy link
Collaborator Author

NiekWe commented Mar 13, 2023

Greying out the whole thing (like BioPen) sounds good to me.

@bellonemauro bellonemauro reopened this Mar 13, 2023
@bellonemauro
Copy link
Owner

ok, but it is not solved yet, I will do that and close the issue when the new version will be out

@bellonemauro
Copy link
Owner

@NiekWe An additional question remains, if I gray out the OM in the interface, what would happen to the commands in the protocols? can one run protocols with OM in ionOptix?

@NiekWe
Copy link
Collaborator Author

NiekWe commented Mar 13, 2023

I guess your question regards to these commands
image
Could on SnR_On_button and SnR_Off_button remain available in the IonOPtix Integration?

@bellonemauro
Copy link
Owner

well, graying out something in the interface using a flag is simple. Changing protocols accordingly would require quite a lot of tweaks and flags around that would make the whole thing messy. This was the reason why originally we decided to split biopen from biozone. The original idea of biozone was just to be -the same- as biopen but with 6 channels, when we got to protocols we realized that the idea was not feasible (not easily at least) and thus the software was split.

One clean solution can be to leave protocols as they are, and just warn the user that those commands cannot be run (if present in the protocol) and prevent their execution.

@NiekWe
Copy link
Collaborator Author

NiekWe commented Mar 13, 2023

Or not warn them at all, right now all these buttons (SnS, LnS, SnR, LnR) lead to exact the same protocol. If the user takes the wrong button the results would be exactly the same as taking the right button.

@bellonemauro
Copy link
Owner

This can be done, I will work on this a bit.

@NiekWe
Copy link
Collaborator Author

NiekWe commented Mar 28, 2023

Could the operational modes be made transparent completely, so you cannot see them?

@NiekWe NiekWe reopened this Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change requested Changes (which are not a bug or enhancement)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants