Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export core config types to have adapters available #568

Closed
devconcept opened this issue Mar 14, 2023 · 2 comments
Closed

Export core config types to have adapters available #568

devconcept opened this issue Mar 14, 2023 · 2 comments
Labels
enhancement released

Comments

@devconcept
Copy link

devconcept commented Mar 14, 2023 •
edited
Loading

This library is awesome but there are features and types not being exported like the JsonAdapter, the FileAdapter and the ConfigWithAdapter just to name a few.

The reason exporting those would be nice is because the functionality already exists and we can use them to test functionality with a MemoryAdapter instead of using real files.
@devconcept devconcept changed the title Export core config type to have adapters available Export core config types to have adapters available Mar 14, 2023
@Belphemur
Copy link
Owner

Hello,

That's a great idea, easy to do too :)

github-actions bot pushed a commit that referenced this issue Mar 14, 2023
@semantic-release-bot
chore(release): 2.1.5 [skip ci]
9569699 
## [2.1.5](v2.1.4...v2.1.5) (2023-03-14)

### Performance Improvements

* **Interoperability:** Export underlying adapter type to let developers customize the storage logic ([cfa874e](cfa874e)), closes [#568](#568)
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 2.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Belphemur @devconcept