Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

muparserx build system? #49

Closed
rashadkm opened this issue Apr 22, 2015 · 8 comments
Closed

muparserx build system? #49

rashadkm opened this issue Apr 22, 2015 · 8 comments

Comments

@rashadkm
Copy link

Is there any plans on improving build system for muparserx? The current "just a makefile" is simple. But that itself forces to have clang or update Makefiles by hand. Even though I dont care for changing the makefile, the solution is not good interms of packaging or using another platform

cmake seems a good option as it is easy to configure and make on more platforms compared to other build tools.

I can provide a pull request, if that is acceptable ?

@martinrotter
Copy link
Contributor

Hello, you have available project files for Qt Creator and Visual Studio. What would you want more? Cmake-based compilation script? Makefile is clean and purposed mainly for cland users, yes, but incorporating muparserx build process into build process of your own application is very simple.

@rashadkm
Copy link
Author

Visual Studio is for windows only. remember same can be generated by cmake.
Qt creator is cross platform. But isnt that too much to have qt creator installed for installing muparserx.
I dont want to press the matter on cmake, or autobuild or QtCreator for that matter.

I was stating, it would be easier to maintain and for use some kind of cross platform. Having Qtcreator in muparserx itself stands for my point.

Yes. If I am bundling muparserx, the alright it is fine. But what If I need to package muparserx so that it can used by other using a linux or osx package manager?

I tried to package this for Fedora Linux. For that either I need to patch Makefile or add QtCreator as a dependency.

@martinrotter
Copy link
Contributor

*.pro files are parsed by qmake utility, no need to actually have Qt Creator installed. It is hard to maintain 4 build types for this tiny project.

@rashadkm
Copy link
Author

I understand the pain in maintaining mulitple build types.

For me on fedora,

yum whatprovides /usr/bin/qmake-qt4 says:

1:qt-devel-4.8.5-10.fc20.i686 : Development files for the Qt toolkit
Dépôt   : fedora
Correspondance depuis :
Nom de fichier : /usr/bin/qmake-qt4

So I need to add a dependency of qt-devel for creating linux packages, it will be a problem for package users to use muparserx. For myself, I dont care for that part..

Note, if you add cmake then you probably dont want to maintain, Makefile, visualstudio and maybe QtCreator

So, this enhancement will not be increasing the count and pain of build system supported by muparserx but rather reducing them.

@guruofquality
Copy link
Contributor

I will second that. CMake is a worthy replacement for multiple build systems and its served me well for cross platform building and packaging. I have put together a CMakeLists.txt here and tested it on several machines: pothosware@2304371

BTW, muparserx is a fantastic project. great work

@aaronpburke
Copy link

+1 for CMake.

@rashadkm
Copy link
Author

FYI,
@guruofquality had a pull request for adding cmake and eventually closing this issue.
#50

waiting for developers to merge this pull.

@beltoforion
Copy link
Owner

Code merged. I'm closing the issue. For details please see #50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants