Skip to content

Commit

Permalink
review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
birhoff committed Feb 22, 2017
1 parent 2620fb2 commit 002d0aa
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
8 changes: 4 additions & 4 deletions index.js
Expand Up @@ -3,8 +3,6 @@
const assert = require('assert');
const util = require('util');

const deprecate = require('depd')('bem-cell');

const BemEntityName = require('@bem/entity-name');

module.exports = class BemCell {
Expand Down Expand Up @@ -104,7 +102,7 @@ module.exports = class BemCell {
* @returns {String|undefined} - modifier name
*/
get modName() {
deprecate('modName: just for compatibility and can be dropped in future');
console.warn('modName: just for compatibility and can be dropped in future');
return this._entity.modName;
}

Expand All @@ -115,7 +113,7 @@ module.exports = class BemCell {
* @returns {String|true|undefined} - modifier value
*/
get modVal() {
deprecate('modVal: just for compatibility and can be dropped in future');
console.warn('modVal: just for compatibility and can be dropped in future');
return this._entity.modVal;
}

Expand Down Expand Up @@ -282,6 +280,8 @@ module.exports = class BemCell {
* const BemCell = require('@bem/cell');
*
* BemCell.create({ block: 'my-button', mod: 'theme', val: 'red', tech: 'css' });
* BemCell.create({ block: 'my-button', modName: 'theme', modVal: 'red', tech: 'css' });
* BemCell.create({ entity: { block: 'my-button', modName: 'theme', modVal: 'red' }, tech: 'css' });
* // BemCell { block: 'my-button', mod: { name: 'theme', val: 'red' }, tech: 'css' }
*
* @param {Object} obj — representation of cell.
Expand Down
3 changes: 1 addition & 2 deletions package.json
Expand Up @@ -24,8 +24,7 @@
"node": ">= 4.0"
},
"dependencies": {
"@bem/entity-name": "1.3.1",
"depd": "^1.1.0"
"@bem/entity-name": "1.3.1"
},
"devDependencies": {
"ava": "^0.17.0",
Expand Down

0 comments on commit 002d0aa

Please sign in to comment.